Revert update to clap-beta back to structopt #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clap-beta hasn't had a release in a while and likely won't for a while longer. We're affected by bugs that have been fixed and not released. We shouldn't be depending on beta software anyways for this.
syrusakbary
reviewed
Jun 3, 2021
| const WASMER_VERSION: &str = env!("CARGO_PKG_VERSION"); | ||
|
|
||
| #[test] | ||
| fn version_string_is_correct() -> anyhow::Result<()> { |
syrusakbary
approved these changes
Jun 3, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap-beta hasn't had a release in a while and likely won't for a while longer. We're affected by bugs that have been fixed and not released. We shouldn't be depending on a beta library anyways when there's a stable equivalent. It's very understandable that the clap developers don't want to be burdened with publishing bug fixes when making major changes something in-progress -- they'd probably just end up with way more bug reports overall for things they never intended to support.
Revert #2162
more context clap-rs/clap#2487 (comment)
Review