Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wasi) Remove the deprecated code #2368

Merged
merged 2 commits into from
May 31, 2021
Merged

chore(wasi) Remove the deprecated code #2368

merged 2 commits into from
May 31, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented May 31, 2021 •
edited
Loading

Description

This PR removes deprecated code from the wasi crate. With the 2.x coming soon, we no longer need this to maintain this code :-).

I don't know what to do with:

pub enum Kind {
    File {
        /// The path on the host system where the file is located
        /// This is deprecated and will be removed soon
        path: PathBuf,

in state/mod.rs. Any clue @MarkMcCaskey?

@Hywan Hywan added the 🎉 enhancement New feature! label May 31, 2021
@Hywan Hywan self-assigned this May 31, 2021
@Hywan
Copy link
Contributor Author

Hywan commented May 31, 2021

bors try

@Hywan Hywan added the 📦 lib-wasi About wasmer-wasi label May 31, 2021
@Hywan
Copy link
Contributor Author

Hywan commented May 31, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented May 31, 2021

Build succeeded:

@bors bors bot merged commit 19cea55 into wasmerio:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubianchi jubianchi jubianchi approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees

@Hywan Hywan

Labels
🎉 enhancement New feature! 📦 lib-wasi About wasmer-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hywan @jubianchi