Copied trap handlers so this will compile for aarch64-linux-android
#2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrijalva-squire
requested review from
MarkMcCaskey and
syrusakbary
as code owners
|
Looks right! Merging |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
syrusakbary
approved these changes
May 26, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to compile Wasmer for android fails with an 'unsupported platform' error. These two additional cases are copied from their neighbors, but properly match against the
aarch64-linux-androidtarget. I don't know enough about what this code is actually doing to know if this is 'right', but it does appear to work.