Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Wasm modules with no imports in the CLI #2290

Merged
merged 2 commits into from
May 4, 2021
Merged

Handle Wasm modules with no imports in the CLI #2290

merged 2 commits into from
May 4, 2021

Conversation

MarkMcCaskey
Copy link
Contributor

Resolves #2282

@MarkMcCaskey MarkMcCaskey requested a review from syrusakbary May 4, 2021 16:46
@MarkMcCaskey MarkMcCaskey requested a review from Hywan as a code owner May 4, 2021 16:46
@MarkMcCaskey MarkMcCaskey changed the title Handle WASI modules with no imports Handle Wasm modules with no imports in the CLI May 4, 2021
@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 4, 2021

Build succeeded:

@bors bors bot merged commit 46024fb into master May 4, 2021
@bors bors bot deleted the fix/handle-wasi-modules-with-no-imports branch May 4, 2021 20:31
@Hywan
Copy link
Contributor

Hywan commented May 6, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasmer can't run non-wasi files (master)
3 participants
@MarkMcCaskey @Hywan @syrusakbary