use rkyv deserialize to replace bincode on jit artifact #2279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So this is applying similar technique to accelerate deserialize an jit artifact. I test by adding this in tests/compiler/serialize.rs, fn test_deserialize:
run it with
Before it was 11-12ms, this PR make it 6-9ms, most of the time around 7ms. The optimization is visible, but we may achieve a faster one via Archive, that is replace all usage of SerializableModule and its fields, to ArchivedSerializableModule - this would make deserialize an O(1) mmap operation, but also add further intrusive changes based on this PR.
Review