Update wasmparser to 0.77 #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
syrusakbary
reviewed
Apr 29, 2021
| @@ -508,510 +520,522 @@ pub enum wasmer_parser_operator_t { | |||
|
|
|||
| impl<'a> From<&Operator<'a>> for wasmer_parser_operator_t { | |||
| fn from(operator: &Operator<'a>) -> Self { | |||
| use Operator::*; | |||
| use Operator as O; | |||
|
We should be ready to go once #2276 lands! |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves multiple failures in #2268
Primarily this is just supporting the new SIMD ops. I also snuck in a change to our WAST test runner to fix another issue...
When updating the C API, I chose to namespace all the
wasmparserOperators we're using because without that, the error messages are really quite bad.SomeStringOfCharactersin a match statement will match anything (it's bound as a variable name) if there's no enum variant that matches.::is not valid in variable names so namespacing it makes it unambiguous that we're trying to match a specific thing, not bind a variable and the error messages we get are much clearer.