-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow CLI to exec WASI w/ multiple namespaces #2251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning when it's done and a flag to opt out of the warning: `--allow-multiple-wasi-versions`
MarkMcCaskey
force-pushed
the
feature/multiple-wasi-versions-in-li
branch
from
April 22, 2021 15:34
b3a17b8
to
bc9706e
Compare
Hywan
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good patch. It looks good to me!
bors try |
tryBuild failed: |
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 28, 2021
2251: Allow CLI to exec WASI w/ multiple namespaces r=MarkMcCaskey a=MarkMcCaskey resolves #2226 Added a warning when it's done and a flag to opt out of the warning: `--allow-multiple-wasi-versions` Wasm module to test with: [mixed-wasi.wasm.tar.gz](https://github.com/wasmerio/wasmer/files/6360575/mixed-wasi.wasm.tar.gz) # Review - [x] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2226
Added a warning when it's done and a flag to opt out of the warning:
--allow-multiple-wasi-versions
Wasm module to test with: mixed-wasi.wasm.tar.gz
Review