Fix UB in setting memory in emscripten EmEnv #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
bors try- |
syrusakbary
approved these changes
Apr 14, 2021
|
bors r+ |
1 similar comment
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 16, 2021
2241: Fix UB in setting memory in emscripten EmEnv r=syrusakbary a=MarkMcCaskey Fixes the UB and another issue caused by the reftypes PR merging in Resolves #2122 Co-authored-by: Mark McCaskey <[email protected]>
|
Timed out. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 16, 2021
2241: Fix UB in setting memory in emscripten EmEnv r=MarkMcCaskey a=MarkMcCaskey Fixes the UB and another issue caused by the reftypes PR merging in Resolves #2122 Co-authored-by: Mark McCaskey <[email protected]>
|
Build failed: |
|
bors r- |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the UB and another issue caused by the reftypes PR merging in
Resolves #2122