Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cranelift: enable SIMD based on actual Wasm features #2224

Merged
merged 12 commits into from
May 15, 2021
Merged

Cranelift: enable SIMD based on actual Wasm features #2224

merged 12 commits into from
May 15, 2021

Conversation

jubianchi
Copy link
Contributor

Review

  • Add a short description of the the change to the CHANGELOG.md file

@jubianchi jubianchi requested a review from syrusakbary March 31, 2021 19:54
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Mar 31, 2021
@bors @jubianchi
Merge #2224
b5b819a 
2224: Cranelift simd r=syrusakbary a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 31, 2021

Build failed:

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Mar 31, 2021
@bors @jubianchi @syrusakbary
Merge #2224
c4a5938 
2224: Cranelift simd r=syrusakbary a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
@jubianchi jubianchi changed the title Cranelift simd Cranelift: enable SIMD based on actual Wasm features Mar 31, 2021
@bors
Copy link
Contributor

bors bot commented Mar 31, 2021

Build failed:

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Mar 31, 2021
@bors @jubianchi @syrusakbary
Merge #2224
affa156 
2224: Cranelift: enable SIMD based on actual Wasm features r=syrusakbary a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 31, 2021

Build failed:

@jubianchi
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 1, 2021
@bors @jubianchi @syrusakbary
Merge #2224
d1cef76 
2224: Cranelift: enable SIMD based on actual Wasm features r=jubianchi a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 1, 2021

Build failed:

@jubianchi
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 1, 2021
@bors
Try #2224:
5472d05
@bors
Copy link
Contributor

bors bot commented Apr 1, 2021

try

Build failed:

MarkMcCaskey
MarkMcCaskey suggested changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messaged about this on Slack, but I don't think we want Features::enable_simd to be related to this other use of simd which is entirely unrelated as I understand it. If we want to control low-level compiler details with Features, I think we need to add new fields, ideally in a new sub-struct to keep things organized

MarkMcCaskey
MarkMcCaskey approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title is misleading now, but my previous objection seems to no longer be in the PR. I do think we need to be careful about separating the ideas of codegen simd from Wasm simd though

@jubianchi
Copy link
Contributor Author

bors try

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Apr 26, 2021
@bors @jubianchi @syrusakbary
Merge #2224
a7edc4b 
2224: Cranelift: enable SIMD based on actual Wasm features r=syrusakbary a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 26, 2021

Build failed:

@syrusakbary syrusakbary mentioned this pull request Apr 30, 2021
Closed
@MarkMcCaskey
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request May 12, 2021
@bors @jubianchi @syrusakbary
Merge #2224
2800483 
2224: Cranelift: enable SIMD based on actual Wasm features r=MarkMcCaskey a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 12, 2021

Build failed:

@syrusakbary
Merge branch 'feature/update-clif-small-simd-improvement' into cranel…
a5ba236 
…ift-simd

# Conflicts:
#	Cargo.lock
#	fuzz/Cargo.lock
#	lib/compiler-cranelift/Cargo.toml
#	lib/deprecated/runtime-core/Cargo.lock
@jubianchi jubianchi requested a review from losfair as a code owner May 14, 2021 21:36
@syrusakbary syrusakbary mentioned this pull request May 15, 2021
Merged
1 task
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 15, 2021
@bors @jubianchi @syrusakbary
Merge #2224
470f691 
2224: Cranelift: enable SIMD based on actual Wasm features r=syrusakbary a=jubianchi

# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: jubianchi <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 15, 2021

Build failed:

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented May 15, 2021

Build succeeded:

@bors bors bot merged commit b145d71 into master May 15, 2021
@bors bors bot deleted the cranelift-simd branch May 15, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@nlewycky nlewycky Awaiting requested review from nlewycky

@losfair losfair Awaiting requested review from losfair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jubianchi @syrusakbary @MarkMcCaskey