feat: Implement MemoryUsage for Module
#2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
requested review from
losfair,
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
1 task
Hywan
force-pushed
the
feat-memory-usage-module
branch
2 times, most recently
from
fd15636 to
553cfc7
Compare
Hywan
changed the title
MemoryUsage for ModuleMemoryUsage for Module
Hywan
force-pushed
the
feat-memory-usage-module
branch
from
e34058e to
6eb646e
Compare
Hywan
force-pushed
the
feat-memory-usage-module
branch
from
6eb646e to
9160d3a
Compare
1 task
Hywan
force-pushed
the
feat-memory-usage-module
branch
from
9160d3a to
deb097c
Compare
syrusakbary
approved these changes
Mar 23, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2200: feat: Implement `MemoryUsage` for `Module` r=Hywan a=Hywan # Description This patch implements `loupe::MemoryUsage` for `wasmer::Module`. ~This PR includes #2199. To review unique patches: https://github.com/Hywan/wasmer/compare/feat-memory-usage...feat-memory-usage-module?expand=1~ # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed: |
`MemoryUsage` is implemented for `[T; N]` only on rustc nightly. Wasmer uses the stable channel of rustc. Thus, we re-implement `MemoryUsage` for `V128` by using `V128.as_slice()`.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2200: feat: Implement `MemoryUsage` for `Module` r=Hywan a=Hywan # Description This patch implements `loupe::MemoryUsage` for `wasmer::Module`. ~This PR includes #2199. To review unique patches: https://github.com/Hywan/wasmer/compare/feat-memory-usage...feat-memory-usage-module?expand=1~ # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed: |
|
bors r- |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2201: feat: Implement `MemoryUsage` for `Instance` r=Hywan a=Hywan # Description This patch implements `loupe::MemoryUsage` for `wasmer::Instance`. ~~This PR includes #2200. To review unique patches: https://github.com/Hywan/wasmer/compare/feat-memory-usage-module...feat-memory-usage-instance?expand=1~~ # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2201: feat: Implement `MemoryUsage` for `Instance` r=Hywan a=Hywan # Description This patch implements `loupe::MemoryUsage` for `wasmer::Instance`. ~~This PR includes #2200. To review unique patches: https://github.com/Hywan/wasmer/compare/feat-memory-usage-module...feat-memory-usage-instance?expand=1~~ # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch implements
loupe::MemoryUsageforwasmer::Module.This PR includes #2199. To review unique patches: https://github.com/Hywan/wasmer/compare/feat-memory-usage...feat-memory-usage-module?expand=1Review