Dust off the fuzzers, update dependencies and use wasm-smith. #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules. Update to newer libfuzzer-sys and use a versioned crates instead of a git repository. Delete "headless_cranelift.rs" which is an older copy of native_cranelift.rs and wasn't referenced in the Cargo.toml.
This wasm module is valid: ``` (module (memory (;0;) 0) (data (;0;) (i32.const 34) "")) ``` and we want to just ignore that problem.
Detect and ignore more errors from singlepass about multi-value returns.
The start function can contain unreachable instructions which triggers a trap and looks like instantiation failed. Instantiation did fail, but not for reasons we're interested in.
syrusakbary
approved these changes
Mar 16, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch compilation tests to wasm-smith which always generates valid modules.
Update to newer libfuzzer-sys and use a versioned crates instead of a git repository.
Delete "headless_cranelift.rs" which is an older copy of native_cranelift.rs and wasn't referenced in the Cargo.toml.