Simplify WasmPtr code #2157
Merged
Simplify WasmPtr code #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::mem::size_of::<T>()` already accounts for end padding. The `align_of` code was not only a no-op, it would be incorrect if it wasn't. Thanks to Matt Itamenye on the wasmerians slack for pointing this out!
nlewycky
approved these changes
Mar 2, 2021
syrusakbary
approved these changes
Mar 3, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 4, 2021
2157: Simplify WasmPtr code r=jubianchi a=MarkMcCaskey `std::mem::size_of::<T>()` already accounts for end padding. The `align_of` code was not only a no-op, it would be incorrect if it wasn't. Thanks to Matt Itamenye on the wasmerians slack for pointing this out! This PR does not change any behavior, only removes misleading code. Co-authored-by: Mark McCaskey <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
bors bot
added a commit
that referenced
this pull request
Mar 4, 2021
2157: Simplify WasmPtr code r=jubianchi a=MarkMcCaskey `std::mem::size_of::<T>()` already accounts for end padding. The `align_of` code was not only a no-op, it would be incorrect if it wasn't. Thanks to Matt Itamenye on the wasmerians slack for pointing this out! This PR does not change any behavior, only removes misleading code. Co-authored-by: Mark McCaskey <[email protected]>
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::mem::size_of::<T>()already accounts for end padding. Thealign_ofcodewas not only a no-op, it would be incorrect if it wasn't.
Thanks to Matt Itamenye on the wasmerians slack for pointing this out!
This PR does not change any behavior, only removes misleading code.