feat(c-api) Reduce the number of dependencies by statically compiling CRT #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
Hywan
added
🎉 enhancement
… CRT.
This patch adds the `-Ctarget-feature=+crt-static` flag when compiling
`libwasmer` on Windows. The goal is twofold: Reducing the number of
dependencies, and improving the portability of `libwasmer.dll` on more
Windows instances.
Before:
```sh
$ objdump --all-headers wasmer.dll | rg 'DLL Name'
DLL Name: bcrypt.dll
DLL Name: ADVAPI32.dll
DLL Name: KERNEL32.dll
DLL Name: VCRUNTIME140.dll
DLL Name: api-ms-win-crt-heap-l1-1-0.dll
DLL Name: api-ms-win-crt-runtime-l1-1-0.dll
DLL Name: api-ms-win-crt-math-l1-1-0.dll
DLL Name: api-ms-win-crt-string-l1-1-0.dll
```
After:
```sh
$ objdump --all-headers wasmer.dll | rg 'DLL Name'
DLL Name: bcrypt.dll
DLL Name: ADVAPI32.dll
DLL Name: KERNEL32.dll
```
Hywan
force-pushed
the
feat-c-api-windows-crt-static
branch
from
bafab27 to
965aa53
Compare
Hywan
added a commit
to wasmerio/wasmer-go
that referenced
this pull request
Feb 25, 2021
Include `wasmer.dll` from wasmerio/wasmer#2140.
|
How big are the sizes before vs after? |
|
It adds <0.1Mb. |
syrusakbary
approved these changes
Feb 26, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds the
-Ctarget-feature=+crt-staticflag when compilinglibwasmeron Windows. The goal is twofold: Reducing the number ofdependencies, and improving the portability of
libwasmer.dllon moreWindows instances.
Before:
After:
Review