-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(c-api) Add an unstable non-standard API to query available engines and compilers #2118
Merged
bors
merged 8 commits into
wasmerio:master
from
Hywan:feat-c-api-engine-compiler-query-api
Feb 12, 2021
Merged
feat(c-api) Add an unstable non-standard API to query available engines and compilers #2118
bors
merged 8 commits into
wasmerio:master
from
Hywan:feat-c-api-engine-compiler-query-api
Feb 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and compilers.
syrusakbary
approved these changes
Feb 11, 2021
jubianchi
approved these changes
Feb 12, 2021
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 12, 2021
2118: feat(c-api) Add an unstable non-standard API to query available engines and compilers r=Hywan a=Hywan # Description This patch adds 3 unstable non-standard C functions: * `wasmer_is_headless`, * `wasmer_is_compiler_available`, * `wasmer_is_engine_available`. The rest of the patch adds tests, documentations, update existing tests, small stuf like that that can now be possible thanks to this new API. I've also released a new version of `inline-c` to remove a warning with the latest `rustc` version. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
Build failed: |
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds 3 unstable non-standard C functions:
wasmer_is_headless
,wasmer_is_compiler_available
,wasmer_is_engine_available
.The rest of the patch adds tests, documentations, update existing tests, small stuf like that that can now be possible thanks to this new API.
I've also released a new version of
inline-c
to remove a warning with the latestrustc
version.Review