Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112

Closed
wants to merge 8 commits into from
Closed

fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112

wants to merge 8 commits into from

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Feb 11, 2021 •
edited
Loading

Description

  1. 7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see Improved Apple Silicon & LLVM 11 support #2008 (comment).
  2. 3946f3c, Second, we copy the ATTRIBUTIONS and LICENSE files twice. That's useless :-).
  3. efff2c8 , Third, as discussed with @MarkMcCaskey, we want to rename wasmer-windows.exe to wasmer-windows-installer.exe for the sake of clarity.
  4. 1a03e88, Fourth, let's create a wasmer.tar.gz archive for Windows.
  5. 67e8679, Fiveth, let's upload the wasmer.tar.gz archive for Windows.
  6. cf0c56c, Use wasmer.zip on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey).

Review

  • Add a short description of the the change to the CHANGELOG.md file not necessary

@Hywan Hywan added 🧪 tests I love tests 🤖 bot Bip bip labels Feb 11, 2021
@Hywan Hywan self-assigned this Feb 11, 2021
@Hywan Hywan changed the title fix(ci) Use our own LLVM built on Windows fix(ci) Clean up Windows artifacts, installer, LLVM etc. Feb 11, 2021
MarkMcCaskey
MarkMcCaskey approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this seems like the kind of thing @syrusakbary might care about too though

Hywan added 2 commits February 11, 2021 16:17
@Hywan
feat(makefile) Create a wasmer.tar.gz for Windows too.
1a03e88
@Hywan
feat(github) Upload the wasmer.tar.gz for Windows.
67e8679 
This patch also removes useless `id` for most steps in the `release`
job.
@Hywan
Copy link
Contributor Author

Hywan commented Feb 11, 2021

bors try

@Hywan
Copy link
Contributor Author

Hywan commented Feb 11, 2021

bors try

@bors
Copy link
Contributor

bors bot commented Feb 11, 2021

try

Already running a review

@Hywan
Copy link
Contributor Author

Hywan commented Feb 11, 2021

bors try-

@Hywan
Copy link
Contributor Author

Hywan commented Feb 11, 2021

bors try

jubianchi
jubianchi suggested changes Feb 11, 2021
View reviewed changes
.github/workflows/main.yaml Outdated Show resolved Hide resolved
@Hywan
Copy link
Contributor Author

Hywan commented Feb 11, 2021

bors try

@bors
Copy link
Contributor

bors bot commented Feb 11, 2021

try

Already running a review

@Hywan Hywan mentioned this pull request Feb 11, 2021
Merged
1 task
@Hywan Hywan closed this Feb 11, 2021
bors bot added a commit that referenced this pull request Feb 11, 2021
@bors @Hywan
Merge #2116
1bdfa93 
2116: fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 r=Hywan a=Hywan

(re-edit of #2112)

# Description

1.  7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see #2008 (comment).
2. 3946f3c, Second, we copy the `ATTRIBUTIONS` and `LICENSE` files twice. That's useless :-).
3. efff2c8 ,  Third, as discussed with @MarkMcCaskey, we want to rename `wasmer-windows.exe` to `wasmer-windows-installer.exe` for the sake of clarity.
4. 1a03e88, Fourth, let's create a `wasmer.tar.gz` archive for Windows.
5. 67e8679, Fiveth, let's upload the `wasmer.tar.gz` archive for Windows.
6. cf0c56c, Use `wasmer.zip` on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey).

# Review

- [ ] ~Add a short description of the the change to the CHANGELOG.md file~ not necessary


Co-authored-by: Ivan Enderlin <[email protected]>
bors bot added a commit that referenced this pull request Feb 11, 2021
@bors @Hywan
Merge #2116
37ff308 
2116: fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 r=Hywan a=Hywan

(re-edit of #2112)

# Description

1.  7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see #2008 (comment).
2. 3946f3c, Second, we copy the `ATTRIBUTIONS` and `LICENSE` files twice. That's useless :-).
3. efff2c8 ,  Third, as discussed with @MarkMcCaskey, we want to rename `wasmer-windows.exe` to `wasmer-windows-installer.exe` for the sake of clarity.
4. 1a03e88, Fourth, let's create a `wasmer.tar.gz` archive for Windows.
5. 67e8679, Fiveth, let's upload the `wasmer.tar.gz` archive for Windows.
6. cf0c56c, Use `wasmer.zip` on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey).

# Review

- [ ] ~Add a short description of the the change to the CHANGELOG.md file~ not necessary


Co-authored-by: Ivan Enderlin <[email protected]>
bors bot added a commit that referenced this pull request Feb 11, 2021
@bors @Hywan
Merge #2116
9f7cae9 
2116: fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 r=Hywan a=Hywan

(re-edit of #2112)

# Description

1.  ~7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see #2008 (comment) Our LLVM built aren't designed for mingw32. Let's keep LLVM from Choco for the moment.
2. 3946f3c, Second, we copy the `ATTRIBUTIONS` and `LICENSE` files twice. That's useless :-).
3. ~efff2c8 ,  Third, as discussed with @MarkMcCaskey, we want to rename `wasmer-windows.exe` to `wasmer-windows-installer.exe` for the sake of clarity.~ It will break the Wasmer installer, so let's keep that name as is.
4. 1a03e88, Fourth, let's create a `wasmer.tar.gz` archive for Windows.
5. 67e8679, Fiveth, let's upload the `wasmer.tar.gz` archive for Windows.
6. cf0c56c, Use `wasmer.zip` on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey).

# Review

- [ ] ~Add a short description of the the change to the CHANGELOG.md file~ not necessary


Co-authored-by: Ivan Enderlin <[email protected]>
bors bot added a commit that referenced this pull request Feb 11, 2021
@bors @Hywan
Merge #2116
40bdfa4 
2116: fix(ci) Clean up Windows artifacts, installer, LLVM etc. #2112 r=Hywan a=Hywan

(re-edit of #2112)

# Description

1.  ~7ff16b4, First, we need to use our own LLVM built for Windows. This has been commited by error, see #2008 (comment) Our LLVM built aren't designed for mingw32. Let's keep LLVM from Choco for the moment.
2. 3946f3c, Second, we copy the `ATTRIBUTIONS` and `LICENSE` files twice. That's useless :-).
3. ~efff2c8 ,  Third, as discussed with @MarkMcCaskey, we want to rename `wasmer-windows.exe` to `wasmer-windows-installer.exe` for the sake of clarity.~ It will break the Wasmer installer, so let's keep that name as is.
4. 1a03e88, Fourth, let's create a `wasmer.tar.gz` archive for Windows.
5. 67e8679, Fiveth, let's upload the `wasmer.tar.gz` archive for Windows.
6. cf0c56c, Use `wasmer.zip` on Windows because it's difficult to untar+ungzip on this OS (as discused with @MarkMcCaskey).

# Review

- [ ] ~Add a short description of the the change to the CHANGELOG.md file~ not necessary


Co-authored-by: Ivan Enderlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@jubianchi jubianchi jubianchi approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees

@Hywan Hywan

Labels
🤖 bot Bip bip 🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hywan @syrusakbary @jubianchi @MarkMcCaskey