Don't #include inside extern "C" blocks. #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also free the malloc'd error string in print_wasmer_error(). Run the C code through clang-format.
nlewycky
requested review from
Hywan,
MarkMcCaskey and
syrusakbary
as code owners
MarkMcCaskey
approved these changes
Feb 11, 2021
Comment on lines
+291
to
+293
| c_statements.push(CStatement::LiteralConstant { | ||
| value: "\n#ifdef __cplusplus\n}\n#endif\n\n".to_string(), | ||
| }); |
There was a problem hiding this comment.
I don't remember much about the abstractions here but it might be nice to have the CPlusPlus guard be a thing that can work on nested data / trees so we don't have to remember to close it ourselves.
Don't let that block this PR though
| int error_len = wasmer_last_error_length(); | ||
| printf("Error len: `%d`\n", error_len); | ||
| char* error_str = (char*) malloc(error_len); | ||
| char *error_str = (char *)malloc(error_len); |
There was a problem hiding this comment.
I will never believe that char *name is more readable or accurate than char* name 😆
There was a problem hiding this comment.
char x, *y, f() is a char, a pointer-to-char and a function that returns a char. What a language! 😆
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 12, 2021
2108: Don't #include inside extern "C" blocks. r=nlewycky a=nlewycky Also free the malloc'd error string in print_wasmer_error(). Run the C code through clang-format. Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: nlewycky <[email protected]>
|
Build failed: |
The header file generated by engine-object-file doesn't #include the wasm types it needs and relies on these being included before it.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 15, 2021
2108: Don't #include inside extern "C" blocks. r=nlewycky a=nlewycky Also free the malloc'd error string in print_wasmer_error(). Run the C code through clang-format. Co-authored-by: Nick Lewycky <[email protected]> Co-authored-by: nlewycky <[email protected]>
Hywan
approved these changes
Feb 15, 2021
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also free the malloc'd error string in print_wasmer_error().
Run the C code through clang-format.