fix: cflags emitted by wasmer config --pkg-config are now correct
#2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubianchi
changed the title
wasmer config --pkg-config are now correct
jubianchi
added a commit
to wasmerio/wasmer-php
that referenced
this pull request
Feb 8, 2021
jubianchi
added a commit
to wasmerio/wasmer-php
that referenced
this pull request
Feb 8, 2021
jubianchi
force-pushed
the
pkg-config-cflags
branch
from
7b5599b to
835b500
Compare
syrusakbary
approved these changes
Feb 9, 2021
|
Merging manually as it doesn't have any test changes (or anything covered by them) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review