fix(c-api) Fix how string's length is computed #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obviously, it's just `feature.size`. Why did I do that…?
Hywan
added a commit
to Hywan/go-ext-wasm
that referenced
this pull request
Feb 5, 2021
There is a small bug in Wasmer, see wasmerio/wasmer#2097. While waiting on the fix, we change the cross-compilation target in our test so that the CI is happy and we can merge the entire PR. The new release of Wasmer will come quickly.
jubianchi
approved these changes
Feb 5, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 5, 2021
2097: fix(c-api) Fix how string's length is computed r=Hywan a=Hywan # Description Obviously, it's just `feature.size`. Why did I do that…? # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed: |
|
CI is failing because the macOS aarch64 machine didn't start. bors r+ |
Hywan
added a commit
to Hywan/go-ext-wasm
that referenced
this pull request
Feb 12, 2021
Because they include wasmerio/wasmer#2097.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Obviously, it's just
feature.size. Why did I do that…?Review