Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update LLVM in the documentation workflow #2089

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

jubianchi
Copy link
Contributor

The documentation workflow is broken since we updated to LLVM 11. This PR fixes that.

@jubianchi jubianchi added bug Something isn't working 📚 documentation Do you like to read? labels Feb 2, 2021
@jubianchi jubianchi requested review from nlewycky and Hywan February 2, 2021 08:53
@jubianchi jubianchi self-assigned this Feb 2, 2021
@@ -30,7 +30,7 @@ jobs:
echo "LLVM_SYS_100_PREFIX=${{ env.LLVM_DIR }}" >> $GITHUB_ENV
env:
LLVM_DIR: ${{ github.workspace }}/llvm-10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LLVM_DIR: ${{ github.workspace }}/llvm-10
LLVM_DIR: ${{ github.workspace }}/llvm-11

@@ -30,7 +30,7 @@ jobs:
echo "LLVM_SYS_100_PREFIX=${{ env.LLVM_DIR }}" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use LLVM_SYS_110_PREFIX here?

@jubianchi
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 2, 2021

@bors bors bot merged commit 3ed1e47 into master Feb 2, 2021
@bors bors bot deleted the llvm-update-doc-gen branch February 2, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📚 documentation Do you like to read?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants