feat(package) Be consistent on Windows regarding libwasmer name.
#2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubianchi
reviewed
Jan 29, 2021
Hywan
force-pushed
the
feat-package-windows
branch
from
ed18f3f to
2e50f63
Compare
jubianchi
approved these changes
Feb 1, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 1, 2021
2074: feat(package) Be consistent on Windows regarding `libwasmer` name. r=jubianchi a=Hywan # Description Windows package libraries aren't named consistently regarding other platforms. This patch fixes that. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file 2083: doc(c-api) Remove inline documentation in `wasmer_wasm.h`, clarification about stability… r=Hywan a=Hywan # Description As suggested in #2053 (comment), this PR removes the automatically generated documentation when building `wasmer_wasm.h`. It also clarifies our position regarding stability, and add a section about the documentation. This PR takes also the opportunity to mark `wasi_env_set_(instance|memory)` as deprecated functions. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Feb 1, 2021
2074: feat(package) Be consistent on Windows regarding `libwasmer` name. r=jubianchi a=Hywan # Description Windows package libraries aren't named consistently regarding other platforms. This patch fixes that. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed: |
MarkMcCaskey
reviewed
Feb 1, 2021
| cp target/release/wasmer_c_api.dll package/lib | ||
| cp target/release/wasmer_c_api.lib package/lib | ||
| cp target/release/wasmer_c_api.dll package/lib/wasmer.dll | ||
| cp target/release/wasmer_c_api.lib package/lib/wasmer.lib |
There was a problem hiding this comment.
It'd be good to check with Syrus on the name inconsistency, if I remember correctly they've always had a different name than other platforms and I believe I've verified that that was intentional in the past
There was a problem hiding this comment.
I just re-checked. This looks good!
syrusakbary
approved these changes
Feb 5, 2021
|
Merging although is going to cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows package libraries aren't named consistently regarding other platforms. This patch fixes that.
Review