Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include 'extern "C"' in our C header files when included in a C++ build. #2066

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Include 'extern "C"' in our C header files when included in a C++ build. #2066

merged 1 commit into from
Jan 27, 2021

Conversation

nlewycky
Copy link
Contributor

Description

Fixes #1952

Review

  • Add a short description of the the change to the CHANGELOG.md file

MarkMcCaskey
MarkMcCaskey approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Even simpler than I expected!

@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 27, 2021

Build succeeded:

@bors bors bot merged commit 17de34c into master Jan 27, 2021
@bors bors bot deleted the features/wasmer_wasm_extern_c branch January 27, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@jubianchi jubianchi Awaiting requested review from jubianchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C-API: undefined reference to `wasmer_last_error_length()'
2 participants
@nlewycky @MarkMcCaskey