Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add align, nofree and nonnull to vmctx pointer. Dereferenceable is still TODO. #2060

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Add align, nofree and nonnull to vmctx pointer. Dereferenceable is still TODO. #2060

merged 3 commits into from
Jan 26, 2021

Conversation

nlewycky
Copy link
Contributor

This gives LLVM more information about the vmctx pointer which it can use for better code generation and faster reasoning while compiling.

@nlewycky
Add align, nofree and nonnull to vmctx pointer.
799f1fd 
Adding dereferenceable is still TODO.
@nlewycky nlewycky requested a review from losfair as a code owner January 26, 2021 19:01
@nlewycky
Copy link
Contributor Author

bors r+

@nlewycky nlewycky removed the request for review from losfair January 26, 2021 22:59
@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 26, 2021

Build succeeded:

@bors bors bot merged commit dabc454 into master Jan 26, 2021
@bors bors bot deleted the feature/llvm-vmctx-attrs branch January 26, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlewycky @syrusakbary @MarkMcCaskey