Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on enumset instead of wasmer_enumset #2056

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

coolreader18
Copy link
Contributor

I'm not sure what ramifications this will have for semver, but since it's still relatively close to the release maybe 1.0.2 could be published and 1.0.{0,1} could be yanked? Not sure.

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jan 25, 2021
2056: Depend on enumset instead of wasmer_enumset r=syrusakbary a=coolreader18

I'm not sure what ramifications this will have for semver, but since it's still relatively close to the release maybe 1.0.2 could be published and 1.0.{0,1} could be yanked? Not sure.


Co-authored-by: Noah <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 25, 2021

Build failed:

@syrusakbary
Copy link
Member

The audit failed because of external reasons to this PR. Merging

@syrusakbary syrusakbary merged commit 8188035 into wasmerio:master Jan 26, 2021
@coolreader18 coolreader18 deleted the upstream-enumset branch January 26, 2021 01:11
@MarkMcCaskey
Copy link
Contributor

Glad to hear it got fixed!

Yeah, so the transition to wasmer-enumset was technically a breaking change (though as far as we know, no one was affected), but because the version we had already shipped was effectively broken, we were fine shipping it without incrementing...

Going the other way though, I'm not sure what the best practice is. This is a pretty exceptional circumstance as far as I know.

Another option which doesn't break anything is to modify the wasmer-enumset crate to just export the real enumset... that could reduce some breakage but it's effectively the same thing and probably not worth it.

I'll talk with the team about this today

@Hywan
Copy link
Contributor

Hywan commented Jan 28, 2021

though as far as we know, no one was affected

Except wasmer-python :-). I can manage dealing with the breakage though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants