Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parallelism of llvm builds with native or object file engine. #2037

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

nlewycky
Copy link
Contributor

On my 24 core system, a 21.5s build of qjs.so (llvm + native) is reduced to an 8.2s build.

@nlewycky nlewycky requested a review from losfair as a code owner January 22, 2021 01:30
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Jan 22, 2021
2037: Improve parallelism of llvm builds with native or object file engine. r=nlewycky a=nlewycky

On my 24 core system, a 21.5s build of qjs.so (llvm + native) is reduced to an 8.2s build.

Co-authored-by: Nick Lewycky <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 22, 2021

Build failed:

@syrusakbary
Copy link
Member

Merging manually, is failing because of macos 11.0 issues in Github actions

@syrusakbary syrusakbary merged commit 4d5481b into master Jan 22, 2021
@bors bors bot deleted the feature/llvm-native-parallel branch January 22, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants