expose trap error from RuntimeError #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
requested review from
Hywan,
MarkMcCaskey and
syrusakbary
as code owners
syrusakbary
approved these changes
Jan 15, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 15, 2021
2026: expose trap error from RuntimeError r=syrusakbary a=ailisp <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> Internal of RuntimeError is private, user can know UserError via `downcast`, but user isn't able to tell the trap code if it's a `Trap`. This PR expose trap code via `RuntimeError#to_trap`. (And, if both downcast returns error and to_trap returns None, user will know it's a `RuntimeError::Generic`, which can be shown by `error.message()`, so there's no need to expose `RuntimeError::Generic` case) # Review - [] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Bo Yao <[email protected]>
|
Canceled. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal of RuntimeError is private, user can know UserError via
downcast, but user isn't able to tell the trap code if it's aTrap. This PR expose trap code viaRuntimeError#to_trap. (And, if both downcast returns error and to_trap returns None, user will know it's aRuntimeError::Generic, which can be shown byerror.message(), so there's no need to exposeRuntimeError::Genericcase)Review