-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/headless wasmer revamp #2011
Merged
syrusakbary
merged 8 commits into
feature/headless-wasmer
from
feature/headless-wasmer-revamp
Jan 12, 2021
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d63490e
Move HOST_TARGET up
syrusakbary 0d40d52
Merge branch 'feature/headless-wasmer' of github.com:wasmerio/wasmer …
syrusakbary 8994a06
Merge branch 'feature/headless-wasmer' of github.com:wasmerio/wasmer …
syrusakbary a9bba97
Improved strip command
syrusakbary 1aa6da0
Improved Linux strip command
syrusakbary 59de326
Merge branch 'feature/headless-wasmer' into feature/headless-wasmer-r…
syrusakbary 35dee40
Fix flags
syrusakbary 74a7162
Removed wasmer-headless bin
syrusakbary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
use anyhow::Result; | ||
syrusakbary marked this conversation as resolved.
Show resolved
Hide resolved
|
||
use wasmer_cli::commands::{Config, Run}; | ||
use wasmer_cli::error::PrettyError; | ||
|
||
use structopt::{clap::ErrorKind, StructOpt}; | ||
|
||
#[derive(Debug, StructOpt)] | ||
#[structopt( | ||
name = "wasmer-headless", | ||
about = "Headless WebAssembly standalone runtime.", | ||
author | ||
)] | ||
/// The options for the wasmer Command Line Interface | ||
enum WasmerCLIOptions { | ||
/// Run a WebAssembly file. Formats accepted: wasm, wat | ||
#[structopt(name = "run")] | ||
Run(Run), | ||
|
||
/// Get various configuration information needed | ||
/// to compile programs which use Wasmer | ||
#[structopt(name = "config")] | ||
Config(Config), | ||
} | ||
|
||
impl WasmerCLIOptions { | ||
fn execute(&self) -> Result<()> { | ||
match self { | ||
Self::Run(options) => options.execute(), | ||
Self::Config(config) => config.execute(), | ||
} | ||
} | ||
} | ||
|
||
fn main() { | ||
// We allow windows to print properly colors | ||
#[cfg(windows)] | ||
colored::control::set_virtual_terminal(true).unwrap(); | ||
|
||
// We try to run wasmer with the normal arguments. | ||
// Eg. `wasmer <SUBCOMMAND>` | ||
// In case that fails, we fallback trying the Run subcommand directly. | ||
// Eg. `wasmer myfile.wasm --dir=.` | ||
let args = std::env::args().collect::<Vec<_>>(); | ||
let command = args.get(1); | ||
let options = match command.unwrap_or(&"".to_string()).as_ref() { | ||
"config" | "run" => WasmerCLIOptions::from_args(), | ||
_ => { | ||
WasmerCLIOptions::from_iter_safe(args.iter()).unwrap_or_else(|e| { | ||
match e.kind { | ||
// This fixes a issue that: | ||
// 1. Shows the version twice when doing `wasmer -V` | ||
// 2. Shows the run help (instead of normal help) when doing `wasmer --help` | ||
ErrorKind::VersionDisplayed | ErrorKind::HelpDisplayed => e.exit(), | ||
_ => WasmerCLIOptions::Run(Run::from_args()), | ||
} | ||
}) | ||
} | ||
}; | ||
|
||
PrettyError::report(options.execute()); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we still need the special casing for
aarch64
macos here? if we're not building on actual aarch64 macos machines, I believe this will not work correctlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I follow why.
HOST_TARGET
will beaarch64-apple-darwin
when cross compiling tomacos-arm64
since we setup the target in cargo config:https://github.com/wasmerio/wasmer/blob/master/.github/workflows/main.yaml#L138-L144
Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume
Will not give the correct results there, but I'm just assuming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just re-checked and you are right, however I just found out the previous logic was also wrong.
This can never be true.
cross_compiling_to_mac_aarch64
will never be yes unless the host is a macOS M1 itselfThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-checking this:
Should return
aarch64-apple-darwin
when cross-compiling. Since it's the default (and only) one installed for that.So we should be good!