Improve WasmerEnv, fix emscripten imports #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Jan 11, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 11, 2021
2005: Improve WasmerEnv, fix emscripten imports r=syrusakbary a=MarkMcCaskey This PR adds two new features to `WasmerEnv`: - `alias = "alias_name"` for specifying additional names to try to find the export by - `optional = true` for specifying that failure to find this export is okay In addition, it fixes some breakages on emscripten introduced by migrating emscripten to `WasmerEnv` naively. I've tested this in `examples/nginx` on the `0.x` branch and Wasmer is able to run nginx again, so this resolves #1997 # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
Build failed: |
|
bors r- |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 11, 2021
2005: Improve WasmerEnv, fix emscripten imports r=MarkMcCaskey a=MarkMcCaskey This PR adds two new features to `WasmerEnv`: - `alias = "alias_name"` for specifying additional names to try to find the export by - `optional = true` for specifying that failure to find this export is okay In addition, it fixes some breakages on emscripten introduced by migrating emscripten to `WasmerEnv` naively. I've tested this in `examples/nginx` on the `0.x` branch and Wasmer is able to run nginx again, so this resolves #1997 # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
bors r+ |
|
Already running a review |
|
bors r- |
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 11, 2021
2005: Improve WasmerEnv, fix emscripten imports r=MarkMcCaskey a=MarkMcCaskey This PR adds two new features to `WasmerEnv`: - `alias = "alias_name"` for specifying additional names to try to find the export by - `optional = true` for specifying that failure to find this export is okay In addition, it fixes some breakages on emscripten introduced by migrating emscripten to `WasmerEnv` naively. I've tested this in `examples/nginx` on the `0.x` branch and Wasmer is able to run nginx again, so this resolves #1997 # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
bors r- |
|
Canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new features to
WasmerEnv:alias = "alias_name"for specifying additional names to try to find the export byoptional = truefor specifying that failure to find this export is okayIn addition, it fixes some breakages on emscripten introduced by migrating emscripten to
WasmerEnvnaively. I've tested this inexamples/nginxon the0.xbranch and Wasmer is able to run nginx again, so this resolves #1997Review