Make jit a default feature for wasmer-wasm-c-api
#1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubianchi
approved these changes
Dec 18, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 18, 2020
1955: Make `jit` a default feature for `wasmer-wasm-c-api` r=MarkMcCaskey a=MarkMcCaskey This makes `cargo build` now work with default features. It should also stop causing the header files to change when running tests. # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
1 task
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
bors bot
added a commit
that referenced
this pull request
Dec 18, 2020
1957: Assert that no files changed during lint r=MarkMcCaskey a=MarkMcCaskey waiting for #1955 to land, then we can merge. The first run should fail because of the header file, then we can fix that and it should pass. If that happens, then everything is working as expected. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Mark McCaskey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
cargo buildnow work with default features. It should also stop causing the header files to change when running tests.Review