-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cmake dependency #1880
Merged
Merged
Remove cmake dependency #1880
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
79fb698
Remove dependency on cmake
syrusakbary 48a4298
Merge branch 'master' into cmake-delete
syrusakbary 0655767
Deleted unused files
syrusakbary 56fa494
Deleted binaries
syrusakbary 6489fee
Changed CHANGELOG
syrusakbary 5666d01
Removed deprecated dir Makefile
syrusakbary 44c9876
Improved formatting of Makefile
syrusakbary 4456624
Updated Makefile
syrusakbary 64c2241
Fixed CLI integration tests
syrusakbary 5919d9a
Fixed lint issues
syrusakbary 7823797
Fixed cross compilation
syrusakbary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,9 @@ | ||
|
||
* | ||
*.o | ||
|
||
|
||
# Unignore files ending with `.c` (i.e. `wasm-c-api-wasi.c`) | ||
!*.c | ||
# Unignore Makefile | ||
!Makefile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
$(info Using provided WASMER_DIR=$(WASMER_DIR)) | ||
|
||
ifeq (,$(wildcard $(WASMER_DIR)/bin/wasmer)) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# ignore wasm-c-api binaries | ||
wasm-c-api-* | ||
test-* | ||
|
||
# Unignore files ending with `.c` (i.e. `wasm-c-api-wasi.c`) | ||
!*.c |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
$(info Using provided WASMER_DIR=$(WASMER_DIR)) | ||
|
||
ifeq (,$(wildcard $(WASMER_DIR)/bin/wasmer)) | ||
CFLAGS = -g -I$(WASMER_DIR)/include | ||
LDFLAGS = -Wl,-rpath,$(WASMER_DIR)/lib | ||
LDLIBS = -L$(WASMER_DIR)/lib -lwasmer | ||
else | ||
CFLAGS = -g -I$(shell $(WASMER_DIR)/bin/wasmer config --includedir) | ||
LDFLAGS = -Wl,-rpath,$(shell $(WASMER_DIR)/bin/wasmer config --libdir) | ||
LDLIBS = $(shell $(WASMER_DIR)/bin/wasmer config --libs) | ||
endif | ||
|
||
$(info * CFLAGS: $(CFLAGS)) | ||
$(info * LDFLAGS: $(LDFLAGS)) | ||
$(info * LDLIBS: $(LDLIBS)) | ||
|
||
CAPI_WASMER_TESTS = \ | ||
test-early-exit test-memory test-wasi \ | ||
test-wat2wasm | ||
|
||
CAPI_BASE_TESTS = \ | ||
wasm-c-api/example/callback wasm-c-api/example/global wasm-c-api/example/hello \ | ||
wasm-c-api/example/memory wasm-c-api/example/reflect wasm-c-api/example/serialize \ | ||
wasm-c-api/example/start wasm-c-api/example/trap | ||
|
||
CAPI_BASE_TESTS_NOT_WORKING = \ | ||
wasm-c-api/example/finalize wasm-c-api/example/hostref wasm-c-api/example/multi \ | ||
wasm-c-api/example/table wasm-c-api/example/threads | ||
|
||
DEPRECATED_TESTS = \ | ||
deprecated/test-context deprecated/test-import-object deprecated/test-module-imports \ | ||
deprecated/test-import-trap deprecated/test-module-serialize \ | ||
deprecated/test-exported-memory deprecated/test-imports deprecated/test-module \ | ||
deprecated/test-exports deprecated/test-instantiate deprecated/test-tables \ | ||
deprecated/test-globals deprecated/test-memory deprecated/test-validate \ | ||
deprecated/test-module-exports deprecated/test-module-import-instantiate | ||
|
||
DEPRECATED_NOT_WORKING = test-import-function test-import-function-callinfo test-wasi-import-object test-emscripten-import-object | ||
|
||
ALL = $(CAPI_BASE_TESTS) $(CAPI_WASMER_TESTS) $(DEPRECATED_TESTS) | ||
|
||
test-%: %.o | ||
deprecated/test-%: deprecated/%.o | ||
|
||
.PHONY: all | ||
all: $(ALL) | ||
|
||
.PHONY: test-capi-wasmer | ||
.SILENT: test-capi-wasmer | ||
test-capi-wasmer: $(CAPI_WASMER_TESTS) | ||
set -o errexit; \ | ||
$(foreach example,$?,echo Running \"$(example)\" example; cd $(shell dirname $(realpath $(example))) && ./$(shell basename $(example)); echo;) | ||
|
||
.PHONY: test-capi-base | ||
.SILENT: test-capi-base | ||
test-capi-base: $(CAPI_BASE_TESTS) | ||
set -o errexit; \ | ||
$(foreach example,$?,echo Running \"$(example)\" example; cd $(shell dirname $(realpath $(example))) && ./$(shell basename $(example)); echo;) | ||
|
||
.PHONY: test-capi-base | ||
.SILENT: test-capi-base | ||
test-capi: test-capi-base test-capi-wasmer | ||
|
||
.PHONY: test-deprecated | ||
.SILENT: test-deprecated | ||
test-deprecated: $(DEPRECATED_TESTS) | ||
set -o errexit; \ | ||
$(foreach example,$?,echo Running \"$(example)\" example; cd $(shell dirname $(realpath $(example))) && ./$(shell basename $(example)); echo;) | ||
|
||
test: test-capi test-deprecated | ||
|
||
.SILENT: clean | ||
.PHONY: clean | ||
clean: | ||
$(foreach file,$(ALL),rm -f $(file).o $(file)) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this change was done because the
tests/integration/cli/assets/qjs.wasm
was a symlink.And once tested, as it was a existing file was quite hard to figure out what was going on.
Much easier to use directly the real files!