Set compiler config to be owned (following wasm-c-api) #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
requested review from
Hywan,
jubianchi,
losfair,
MarkMcCaskey and
nlewycky
as code owners
|
bors try |
tryBuild failed: |
MarkMcCaskey
approved these changes
Dec 4, 2020
| @@ -207,8 +207,8 @@ impl CompilerConfig for LLVM { | |||
| } | |||
|
|
|||
| /// Transform it into the compiler. | |||
| fn compiler(&self) -> Box<dyn Compiler + Send> { | |||
| Box::new(LLVMCompiler::new(&self)) | |||
| fn compiler(self: Box<Self>) -> Box<dyn Compiler + Send> { | |||
There was a problem hiding this comment.
Consider using From/Into traits here; not sure how this is used but that could be a bit cleaner
There was a problem hiding this comment.
I tried, couldn't make it work with From. We can do it in a PR apart if necessary
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 4, 2020
1874: Set compiler config to be owned (following wasm-c-api) r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Set compiler config to be owned (following wasm-c-api) <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
Build failed: |
|
Merging directly to alleviate CI. Tests are passing locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set compiler config to be owned (following wasm-c-api)
Review