-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more examples on the Rust API #1785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Nov 2, 2020
webmaster128
reviewed
Nov 2, 2020
jubianchi
force-pushed
the
more-examples
branch
3 times, most recently
from
November 3, 2020 22:22
254cf40
to
b991c7a
Compare
jubianchi
force-pushed
the
more-examples
branch
from
November 3, 2020 22:23
b991c7a
to
70103dd
Compare
syrusakbary
reviewed
Nov 3, 2020
examples/errors.rs
Outdated
Comment on lines
1
to
2
//! A Wasm module can sometimes not work, it will produce errors in some | ||
//! cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
//! A Wasm module can sometimes not work, it will produce errors in some | |
//! cases. | |
//! A Wasm module can sometimes be invalid or trigger traps, and in those case we will get | |
//! an error back from the API. |
syrusakbary
reviewed
Nov 3, 2020
syrusakbary
reviewed
Nov 3, 2020
syrusakbary
approved these changes
Nov 3, 2020
jubianchi
force-pushed
the
more-examples
branch
from
November 4, 2020 15:27
70103dd
to
b2177a8
Compare
syrusakbary
approved these changes
Nov 4, 2020
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wasmerio/docs.wasmer.io
here:Review