Improve LimitingTunables implementation (Tunables example) #1775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
limit
consistently to avoid confusion withmaximum
.limit
inmemory_style
. Without this change, memories that have no maximum when requested derive the style from the requested memory, not from the adjusted one. So when running this example on Windows, we got a dynamic memory before this PR and get a static memory now.memory_style
signature does not allow errors, the logic was changed to an adjust memory to something potentially broken, validate later approach. Do we really want to keep this limitation? Or should implementors be allowed to return errors inmemory_style
?Ps.: I'm heavily unit testing this in our project. But I assume those don't belong here, right?
Review