Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LimitingTunables implementation (Tunables example) #1775

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

webmaster128
Copy link
Contributor

Description

  1. Rename the configured memory limit to limit consistently to avoid confusion with maximum.
  2. Adjust memory type using the limit in memory_style. Without this change, memories that have no maximum when requested derive the style from the requested memory, not from the adjusted one. So when running this example on Windows, we got a dynamic memory before this PR and get a static memory now.
  3. Since the memory_style signature does not allow errors, the logic was changed to an adjust memory to something potentially broken, validate later approach. Do we really want to keep this limitation? Or should implementors be allowed to return errors in memory_style?

Ps.: I'm heavily unit testing this in our project. But I assume those don't belong here, right?

Review

  • Add a short description of the the change to the CHANGELOG.md file

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 29, 2020

@bors bors bot merged commit 6ec9777 into wasmerio:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants