Move function call trampolines to Artifact instead of EngineInner.

[nlewycky]

Description

Move function call trampolines to Artifact instead of EngineInner.

Review

• Add a short description of the the change to the CHANGELOG.md file

[syrusakbary]

We can also delete the engine register_signature.

And with a bit more effort, we could do the lookup_signature as well

Thoughts @nlewycky ?

[nlewycky]

We can also delete the engine register_signature.

And with a bit more effort, we could do the lookup_signature as well

Thoughts @nlewycky ?

I tried removing them while making this PR, then had to put them back. We still need a single signature index across all Instances in the same Store. I can investigate trying again once this PR has landed.

[syrusakbary]

We can also delete the engine register_signature.

I believe register_signature is no longer used anywhere?

[nlewycky]

We can also delete the engine register_signature.

I believe register_signature is no longer used anywhere?

wasmer/lib/api/src/externals/function.rs

Line 379 in ff15be3

.register_signature(&self.exported.signature);

    pub(crate) fn checked_anyfunc(&self) -> VMCallerCheckedAnyfunc {
        let vmsignature = self
            .store
            .engine()
            .register_signature(&self.exported.signature);
        VMCallerCheckedAnyfunc {
            func_ptr: self.exported.address,
            type_index: vmsignature,
            vmctx: self.exported.vmctx,
        }
    }

[syrusakbary]

bors try

[bors]

try

Build succeeded:

• Code lint
• Audit
• Test on macos
• Test on linux
• Test on windows
• Test on linux-aarch64

[nlewycky]

bors r+

[bors]

Build succeeded:

• Audit
• Code lint
• Test on linux
• Test on linux-aarch64
• Test on macos
• Test on windows