Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sentinel value in wasm_limits_t for memory in wasm_c_api #1688

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Fix sentinel value in wasm_limits_t for memory in wasm_c_api #1688

merged 1 commit into from
Oct 8, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

FIxes issue mentioned in #1631 (comment)

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 8, 2020

Build succeeded:

@bors bors bot merged commit 70baded into master Oct 8, 2020
@bors bors bot deleted the feature/memory-max-default-c-api branch October 8, 2020 00:34
@Hywan
Copy link
Contributor

Hywan commented Oct 8, 2020

👍

@Hywan
Copy link
Contributor

Hywan commented Oct 8, 2020

The sentinel value wasn't used in wasm_memorytype_limits. Fixed by #1690.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkMcCaskey @Hywan @syrusakbary