Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack probes are not ordinary functions. #1671

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Stack probes are not ordinary functions. #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a593c88
Stack probes are not ordinary functions.
nlewycky Oct 2, 2020
54d671e
Add a changelog entry.
nlewycky Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## **[Unreleased]**
- [#1671](https://github.com/wasmerio/wasmer/pull/1671) Fix probestack firing inappropriately, and sometimes over/under allocating stack.
- [#1657](https://github.com/wasmerio/wasmer/pull/1657) Implement `wasm_trap_t` and `wasm_frame_t` for Wasm C API; add examples in Rust and C of exiting early with a host function.
- [#1645](https://github.com/wasmerio/wasmer/pull/1645) Move the install script to https://github.com/wasmerio/wasmer-install

Expand Down
7 changes: 3 additions & 4 deletions lib/vm/src/libcalls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,11 +396,10 @@ pub unsafe extern "C" fn wasmer_raise_trap(trap_code: TrapCode) -> ! {
///
/// # Safety
///
/// To be defined (TODO)
/// This function does not follow the standard function ABI, and is called as
/// part of the function prologue.
#[no_mangle]
pub unsafe extern "C" fn wasmer_probestack() {
PROBESTACK();
}
pub static wasmer_probestack: unsafe extern "C" fn() = PROBESTACK;

/// The name of a runtime library routine.
///
Expand Down