Allow mapdir aliases with starting /
#1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stripping leading `/` is valid because we mount mapped dirs at `/` regardless.
|
Can we add tests to the PR? |
added 2 commits
September 30, 2020 16:35
f3af784fb Add mapdir with leading slash test git-subtree-dir: tests/wasi-wast git-subtree-split: f3af784fb148ccd5037ae159c39e99b372bad1cf
…ses-with-leading-slash
syrusakbary
approved these changes
Oct 1, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2020
1660: Allow mapdir aliases with starting `/` r=syrusakbary a=MarkMcCaskey Stripping leading `/` is valid because we mount mapped dirs at `/` regardless. Resolves #1503 This solution is a bit hacky, there may be a more elegant solution. I'll look for one tomorrow morning when I'm more mentally fresh. - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
bors r- |
|
Canceled. |
syrusakbary
reviewed
Oct 1, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2020
1660: Allow mapdir aliases with starting `/` r=MarkMcCaskey a=MarkMcCaskey Stripping leading `/` is valid because we mount mapped dirs at `/` regardless. Resolves #1503 This solution is a bit hacky, there may be a more elegant solution. I'll look for one tomorrow morning when I'm more mentally fresh. - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
Build failed: |
MarkMcCaskey
force-pushed
the
fix/aliases-with-leading-slash
branch
from
7e097b4 to
7612270
Compare
|
bors r- |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2020
1660: Allow mapdir aliases with starting `/` r=MarkMcCaskey a=MarkMcCaskey Stripping leading `/` is valid because we mount mapped dirs at `/` regardless. Resolves #1503 This solution is a bit hacky, there may be a more elegant solution. I'll look for one tomorrow morning when I'm more mentally fresh. - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
Build failed: |
MarkMcCaskey
force-pushed
the
fix/aliases-with-leading-slash
branch
from
f090e29 to
614e4f7
Compare
|
bors r- |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2020
1660: Allow mapdir aliases with starting `/` r=MarkMcCaskey a=MarkMcCaskey Stripping leading `/` is valid because we mount mapped dirs at `/` regardless. Resolves #1503 This solution is a bit hacky, there may be a more elegant solution. I'll look for one tomorrow morning when I'm more mentally fresh. - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
Build failed: |
These tests are failing because we call `take(N)` on chars of a string read from a file. It seems that on Windows, the programs get line endings with `\r\n`, this is a problem for the way our tests assert correct output. We'll need to find a general solution to this problem later.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripping leading
/is valid because we mount mapped dirs at/regardless.Resolves #1503
This solution is a bit hacky, there may be a more elegant solution. I'll look for one tomorrow morning when I'm more mentally fresh.