Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration docs #1649

Merged
merged 6 commits into from
Nov 16, 2020
Merged

Add migration docs #1649

merged 6 commits into from
Nov 16, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Sep 25, 2020 •
edited
Loading

Part of #1553

rendered

Review

  • Add a short description of the the change to the CHANGELOG.md file

syrusakbary
syrusakbary reviewed Sep 25, 2020
View reviewed changes
docs/migration_to_1.0.0.md
If you already have wasmer installed, run `wasmer self-update`.

Install the latest versions of wasmer with [wasmer-nightly].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on NEAR suggestion, we should also add a ## Errors section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we had something about commons errors and how to fix them, I think the best place would be the documentation.

Thoughts?

@codecov-commenter

This comment has been minimized.

Sign in to view
@codecov-io
Copy link

Codecov Report

Merging #1649 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1649   +/-   ##
=======================================
  Coverage   31.73%   31.73%           
=======================================
  Files         185      185           
  Lines       26999    26999           
=======================================
  Hits         8567     8567           
  Misses      18432    18432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f3f0e...4f9afca. Read the comment docs.

@jubianchi jubianchi force-pushed the docs/migration-doc branch 2 times, most recently from b2f52fb to 81caeb3 Compare November 5, 2020 17:55
@jubianchi jubianchi self-assigned this Nov 5, 2020
@jubianchi jubianchi added 🎉 enhancement New feature! 📚 documentation Do you like to read? labels Nov 5, 2020
syrusakbary
syrusakbary approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need to expand a bit more, but this is a great start.
We can expand in further PRs if needed

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 16, 2020

Build succeeded:

@bors bors bot merged commit 958da6c into master Nov 16, 2020
@bors bors bot deleted the docs/migration-doc branch November 16, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubianchi jubianchi jubianchi left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@nlewycky nlewycky Awaiting requested review from nlewycky

Assignees

@jubianchi jubianchi

Labels
📚 documentation Do you like to read? 🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarkMcCaskey @codecov-commenter @codecov-io @syrusakbary @jubianchi