Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-engine) Panic if gcc/clang-10 is missing #1619

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Sep 14, 2020

When gcc or clang-10 is absent, we get a non-obvious error:

Compilation error: No such file or directory (os error 2)

It comes from

let output = Command::new(linker)
.arg(&filepath)
.arg("-o")
.arg(&shared_filepath)
.args(&target_args)
// .args(&wasmer_symbols)
.arg("-shared")
.args(&cross_compiling_args)
.arg("-v")
.output()
.map_err(to_compile_error)?;
.

This PR improves that by panicking when gcc or clang isn't present.

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 14, 2020

Build succeeded:

@bors bors bot merged commit 850fef7 into wasmerio:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants