Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug relating to type conversion in function calls #1602

Merged
merged 3 commits into from
Sep 11, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## **[Unreleased]**
- [#1602](https://github.com/wasmerio/wasmer/pull/1602) Fix panic when calling host functions with negative numbers in certain situations
MarkMcCaskey marked this conversation as resolved.
Show resolved Hide resolved
- [#1590](https://github.com/wasmerio/wasmer/pull/1590) Fix soundness issue in API of vm::Global
- [#1566](https://github.com/wasmerio/wasmer/pull/1566) Add support for opening special Unix files to the WASI FS

Expand Down
30 changes: 29 additions & 1 deletion lib/api/src/externals/function.rs
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,39 @@ mod inner {
};
}

macro_rules! from_to_native_wasm_type_same_size {
( $( $type:ty => $native_type:ty ),* ) => {
$(
#[allow(clippy::use_self)]
unsafe impl FromToNativeWasmType for $type {
type Native = $native_type;

#[inline]
fn from_native(native: Self::Native) -> Self {
unsafe {
std::mem::transmute::<$native_type, $type>(native)
MarkMcCaskey marked this conversation as resolved.
Show resolved Hide resolved
}
}

#[inline]
fn to_native(self) -> Self::Native {
unsafe {
std::mem::transmute::<$type, $native_type>(self)
}
}
}
)*
};
}

from_to_native_wasm_type!(
i8 => i32,
u8 => i32,
i16 => i32,
u16 => i32,
u16 => i32
);

from_to_native_wasm_type_same_size!(
MarkMcCaskey marked this conversation as resolved.
Show resolved Hide resolved
i32 => i32,
u32 => i32,
i64 => i64,
Expand Down