-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the minimum rust version to 1.45.2. #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I think we also need to update the singlepass dyn asm dep (and Cargo.lock) for this to work on stable
Done! |
bors r+ |
1554: Bump the minimum rust version to 1.45.2. r=nlewycky a=nlewycky # Description Bump the minimum required rustc version to 1.45.2, marking the first time that singlepass will be able to build without a nightly compiler. This is a bit ahead of schedule (we normally support one behind the most recent stable) but we expect the next stable to be released in about a week, which should happen before this commit is released. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <[email protected]>
Canceled. |
bors r+ |
1554: Bump the minimum rust version to 1.45.2. r=nlewycky a=nlewycky # Description Bump the minimum required rustc version to 1.45.2, marking the first time that singlepass will be able to build without a nightly compiler. This is a bit ahead of schedule (we normally support one behind the most recent stable) but we expect the next stable to be released in about a week, which should happen before this commit is released. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Nick Lewycky <[email protected]>
Canceled. |
bors r+ |
Build succeeded:
|
Description
Bump the minimum required rustc version to 1.45.2, marking the first time that singlepass will be able to build without a nightly compiler.
This is a bit ahead of schedule (we normally support one behind the most recent stable) but we expect the next stable to be released in about a week, which should happen before this commit is released.
Review