Refactored bin commands into separate files #1357
Merged
+1,218
−1,266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewycky
approved these changes
Apr 6, 2020
src/commands/run.rs
Outdated
| use std::path::PathBuf; | ||
| use std::process::exit; | ||
| use std::str::FromStr; | ||
| use wasmer_runtime::compile_with_config_with; |
There was a problem hiding this comment.
Move this down with rest of wasmer_runtime?
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 6, 2020
1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
MarkMcCaskey
approved these changes
Apr 6, 2020
src/utils.rs
Outdated
| let mut file = File::open(path)?; | ||
| file.read_to_end(&mut buffer)?; | ||
| // We force to close the file | ||
| drop(file); |
There was a problem hiding this comment.
This doesn't do anything, we can remove it!
Build failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
1349: Move integration tests to `tests` dir in workspace root r=MarkMcCaskey a=MarkMcCaskey Reorganizing some of our tests. Still tests left to migrate and a few bugs to fix. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file 1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
1349: Move integration tests to `tests` dir in workspace root r=MarkMcCaskey a=MarkMcCaskey Reorganizing some of our tests. Still tests left to migrate and a few bugs to fix. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file 1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]> Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build failed (retrying...)
|
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build failed |
|
Rage against the machine 🤘. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
bors r- |
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
1357: Refactored bin commands into separate files r=syrusakbary a=syrusakbary <!-- Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test: https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests --> # Description Refactored bin commands into separate files. This PR does not do any sustancial changes other than refactoring into different files for better readability. <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Syrus <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build failed
|
|
bors r+ |
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored bin commands into separate files.
This PR does not do any sustancial changes other than refactoring into different files for better readability.
Review