Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple custom sections with the same name #1320

Merged
merged 2 commits into from
Mar 21, 2020
Merged

Support multiple custom sections with the same name #1320

merged 2 commits into from
Mar 21, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

The spec doesn't disallow duplicates and the JS API spec supports them.

Review

  • Add a short description of the the change to the CHANGELOG.md file

@MarkMcCaskey MarkMcCaskey added the 📦 lib-deprecated About the deprecated crates label Mar 20, 2020
@MarkMcCaskey MarkMcCaskey requested a review from Hywan as a code owner March 20, 2020 18:31
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 20, 2020
@bors
Try #1320:
8a8a6ae
@bors
Copy link
Contributor

bors bot commented Mar 20, 2020

try

Build succeeded

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 21, 2020

Build succeeded

@bors bors bot merged commit 704c342 into master Mar 21, 2020
@bors bors bot deleted the feature/wasm-spec-custom-sections-update branch March 21, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

Assignees
No one assigned
Labels
📦 lib-deprecated About the deprecated crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @syrusakbary