-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Windows Wasmer icons. Add wax #1286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just need to add it for unix-likes and it should be good to go
@@ -287,6 +287,8 @@ build-install-package: | |||
mkdir -p ./install/bin | |||
cp ./wapm-cli/target/release/wapm ./install/bin/ | |||
cp ./target/release/wasmer ./install/bin/ | |||
# Create the wax binary as symlink to wapm | |||
cd ./install/bin/ && ln -s wapm wax | |||
tar -C ./install -zcvf wasmer.tar.gz bin/wapm bin/wasmer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swinging by to check out wax and finding it missing in the release tarballs. Should bin/wax
be added to the list here?
If I manually run ln -s $HOME/.wasmer/bin/wapm $HOME/.wasmer/bin/wax
, the wax command works for me locally after installing via curl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting us know! I'm looking into this now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a retro on our release process and will be making some changes to reduce the chance of something like this happening again. Thanks again for reporting this and verifying that it was working on your end after we shipped the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the link to our retro where we analyzed the issues during the release process:
https://www.notion.so/wasmer/March-12-Release-Retrospective-2a5d1b79005f43fe9ee6a035cf0b5921
Thanks for the ping @lmorchard!
Description
Updated Wasmer icons. Updated wax
Review