feat(interface-types) Implement string and memory instructions #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded |
syrusakbary
approved these changes
Mar 10, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 10, 2020
1284: feat(interface-types) Implement string and memory instructions r=Hywan a=Hywan Previously, we had `read-utf8` and `write-utf8` instructions. The latest version of the standard proposes respectively `memory-to-string` and `string-to-memory`. The semantics is close though. Co-authored-by: Ivan Enderlin <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
bors bot
added a commit
that referenced
this pull request
Mar 12, 2020
1285: feat(interface-types) Greatly improve errors r=Hywan a=Hywan ~This PR is build on top of #1284. It must be merged first. [View the exact diff](https://github.com/Hywan/wasmer/compare/feat-interface-types-instructions-string-and-memory...Hywan:feat-interface-types-better-error?expand=1).~ Errors in `wasmer-interface-types` were just `&'static str`, which isn't quite great 😉. This PR introduces the `errors` module, with structures that represent errors. A `Display` implementation maps the errors to strings. Co-authored-by: Ivan Enderlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had
read-utf8andwrite-utf8instructions. The latest version of the standard proposes respectivelymemory-to-stringandstring-to-memory. The semantics is close though.