Fix floating point calling convention for DynamicFunc trampolines.
#1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
losfair
commented
Mar 5, 2020
losfair
commented
- Allocate GPR/XMM registers according to on argument types in runtime-core/trampoline_x64.
- Previously singlepass used GPR for all arguments. Needs to be fixed.
Hywan
added
bug
bors bot
added a commit
that referenced
this pull request
Mar 12, 2020
1283: Workaround for floating point arguments and return values in `DynamicFunc`s. r=syrusakbary a=losfair This PR makes floating point arguments and return values for `DynamicFunc`s work correctly in all three backends. Previously Singlepass used integer registers for all arguments. This PR adds another thin trampoline layer just before control is transferred to the import function, so that arguments will be rearranged strictly according to the System V ABI. The full fix would require singlepass to implement the SysV calling convention internally too: #1271 . This is just a workaround. Co-authored-by: Ivan Enderlin <[email protected]> Co-authored-by: losfair <[email protected]> Co-authored-by: Heyang Zhou <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
I believe this is fixed in wasmer Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.