Fix WASI directory bugs, improve WASI preopen APIs #1263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bors bot
added a commit
that referenced
this pull request
Mar 4, 2020
1267: Improve support for preopened directories in WASI syscalls r=MarkMcCaskey a=MarkMcCaskey Ported over from #1263 # Description <!-- Provide details regarding the change including motivation, links to related issues, and the context of the PR. --> # Review - [x] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Mark McCaskey <[email protected]>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Probably still relevant. |
|
I believe this is already fixed on master. In case is not, we will need to re-implement/reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with the
/, adds support for preopened directories with/in it and./in it:./forces it to open in "the current directory" (.(technically/.due to the implementation))/opens it in the root.//in a preopen alias will traverse the filesystem and open directories as neededNew logic likely not fully applied,
WasiFs::new()does not support the new logic (this is still used ingenerate_import_object_snapshot0....)I just realized I didn't retest the
--dir=a/b/ccase at all, that logic has not been updated hereReview