Check for unused excluded spectest failures. #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losfair
requested review from
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
|
bors try |
tryBuild failed |
|
bors try |
tryBuild failed |
losfair
force-pushed
the
feature/spectest-check-excluded
branch
from
0fb2550 to
f717d4c
Compare
|
bors try |
tryBuild succeeded
|
syrusakbary
approved these changes
Feb 21, 2020
|
(merged without bors as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a spectest failure was (maybe unintentionally) fixed then the corresponding line in
excludes.txtwill be silently ignored. This PR adds a check that each excluded spectest failure actually occurred.