-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interface-types) Implement the WAT decoder #1232
Merged
bors
merged 11 commits into
wasmerio:master
from
Hywan:feat-interface-types-decoders-wat
Feb 21, 2020
Merged
feat(interface-types) Implement the WAT decoder #1232
bors
merged 11 commits into
wasmerio:master
from
Hywan:feat-interface-types-decoders-wat
Feb 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
🎉 enhancement
New feature!
🧪 tests
I love tests
📚 documentation
Do you like to read?
📦 lib-interface-types
labels
Feb 19, 2020
Almost there! A public API is missing, and documentation of course. |
MarkMcCaskey
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me! I didn't notice anything that could be improved -- checked the docs for wast
too and didn't see anything there that I thought you could use to improve it
This comment has been minimized.
This comment has been minimized.
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 21, 2020
1232: feat(interface-types) Implement the WAT decoder r=Hywan a=Hywan WIP The goal is the define a minimal WAT to AST decoder for WIT, so that it's muuuuuuch easier to develop and debug. Co-authored-by: Ivan Enderlin <[email protected]>
bors r- |
Canceled |
bors r+ |
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
The goal is the define a minimal WAT to AST decoder for WIT, so that it's muuuuuuch easier to develop and debug.