chore(runtime-core) Some code clean ups #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are not necessary for the user. It's only internal implementation, that must be public because it ends up in public types, but the compiler infers everything automatically.
Hywan
added
🎉 enhancement
|
bors r+ |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
Canceled |
|
bors r+ |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
1 similar comment
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
Merge conflict |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 17, 2020
1226: chore(runtime-core) Some code clean ups r=syrusakbary a=Hywan Extracted from #1018. Opinionated patch. Some code clean ups, mostly renaming `ExternalFunction` to `HostFunction`. Co-authored-by: Ivan Enderlin <[email protected]> Co-authored-by: Ivan Enderlin <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1018. Opinionated patch.
Some code clean ups, mostly renaming
ExternalFunctiontoHostFunction.