Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memory mod.rs to include missing mod statement on Windows #122

Closed
wants to merge 1 commit into from

Conversation

JohnDoneth
Copy link

Closes wasmerio/wasmer-rust-example#3

Fixes the missing mod statement that exists in the Unix variant of this file. Currently it's blocking any building on Windows.

Fix the missing mod statement that exists in the Unix variant of this file but not this one.
@CryZe
Copy link
Contributor

CryZe commented Jan 25, 2019

This doesn't fix building on Windows though. The memory module itself has a ton of errors and once that builds there's even more in the clif-backend.

@JohnDoneth
Copy link
Author

@CryZe Ah, my apologies, I should have checked.

@CryZe
Copy link
Contributor

CryZe commented Jan 25, 2019

It seems a lot of new people that came here from the blog post ran into this though. So maybe we could all band together with the guys in #51 to make Windows support happen.

@JohnDoneth JohnDoneth closed this Jan 25, 2019
@xmclark
Copy link
Contributor

xmclark commented Jan 25, 2019

Windows support is crucial for adoption! Expect to see more progress on #51 soon!

@lachlansneff
Copy link
Contributor

To expand on @xmclark comment, Windows support is very important to us! There's quite a bit of work to do before it can work, however. I'll lay it out here:

  1. Get sys::Memory working in Windows.
  2. Add signal catching support for Windows. Currently, we use sigaction, setjmp, and longjmp for this.
  3. Fix any build/linking issues. We recently made a big leap with that by removing the libffi dependency, but there may be additional work to do here.

@lachlansneff
Copy link
Contributor

We've just gotten windows support working, so this has been solved. It's currently in a pr, but we expect window support to be available in the 0.2.0 release.

@CryZe
Copy link
Contributor

CryZe commented Feb 14, 2019

Nice, I'll give it a try tomorrow :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants